Skip to content

Conversation

dhawton
Copy link
Member

@dhawton dhawton commented Aug 11, 2025

Description

This is everything but a make update_all, due to a golangci-lint issue:

WARN [runner] Can't run linter goanalysis_metalinter: inspect: failed to load package framework: could not load export data: no export data for "[istio.io/istio/pkg/test/framework](http://istio.io/istio/pkg/test/framework)"
ERRO Running error: can't run linter goanalysis_metalinter

Will need to look into this when I get some cycles

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@dhawton dhawton requested a review from a team as a code owner August 11, 2025 23:41
@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 11, 2025
Signed-off-by: Daniel Hawton <[email protected]>
@dhawton dhawton force-pushed the master-1754953588 branch from c7b7440 to 3444251 Compare August 12, 2025 11:20
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 13, 2025
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 14, 2025
@dhawton
Copy link
Member Author

dhawton commented Aug 14, 2025

Honestly, not sure what to do here.. this needs to go in so master can properly track istio's master branch.. and I don't have the bandwidth to troubleshoot the cryptic golangci-lint error. In the past it was resolved with go mod tidy but this seems to be something else.

@Ajay-singh1
Copy link
Member

/retest

@Ajay-singh1
Copy link
Member

go get istio.io/api@master
go mod tidy
Will fix this.

Signed-off-by: Daniel Hawton <[email protected]>
@istio-testing istio-testing merged commit cdde45c into istio:master Aug 20, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants